badalprasadsingh commented on code in PR #524:
URL: https://github.com/apache/iceberg-go/pull/524#discussion_r2354376847
##########
manifest.go:
##########
@@ -1546,18 +1689,39 @@ func (d *dataFile) initializeMapData() {
d.fieldIDToPartitionData = make(map[int]any,
len(d.PartitionData))
for k, v := range d.PartitionData {
if id, ok := d.fieldNameToID[k]; ok {
- d.fieldIDToPartitionData[id] = v
+ convertedValue :=
d.convertAvroValueToIcebergType(v, id)
+ d.fieldIDToPartitionData[id] =
convertedValue
}
}
}
- d.fieldIDToPartitionData =
avroPartitionData(d.fieldIDToPartitionData, d.fieldIDToLogicalType)
})
}
+func (d *dataFile) convertAvroValueToIcebergType(v any, fieldID int) any {
+ if t, ok := v.(time.Time); ok {
+ if logicalType, hasLogical := d.fieldIDToLogicalType[fieldID];
hasLogical {
+ switch logicalType {
+ case avro.Date:
+ days := int32(t.Truncate(24*time.Hour).Unix() /
int64((time.Hour * 24).Seconds()))
+
+ return Date(days)
+ case avro.TimestampMicros:
+ return Timestamp(t.UTC().UnixMicro())
Review Comment:
well, we shouldn't be using `avroPartitionData` while reading, as it's whole
purpose is to convert `Iceberg` types -> `Avro Union (map)` format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
