nastra commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2354798259
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -134,45 +134,8 @@ public S3FileIO(SerializableSupplier<S3Client> s3) {
* @param s3Async s3Async supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3,
SerializableSupplier<S3AsyncClient> s3Async) {
- this(s3, s3Async, new S3FileIOProperties());
- }
-
- /**
- * Constructor with custom s3 supplier and S3FileIO properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information
set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier)} with {@link
S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(SerializableSupplier<S3Client> s3, S3FileIOProperties
s3FileIOProperties) {
- this(s3, null, s3FileIOProperties);
- }
-
- /**
- * Constructor with custom s3 supplier, s3Async supplier and S3FileIO
properties.
- *
- * <p>Calling {@link S3FileIO#initialize(Map)} will overwrite information
set in this constructor.
- *
- * @param s3 s3 supplier
- * @param s3Async s3Async supplier
- * @param s3FileIOProperties S3 FileIO properties
- * @deprecated since 1.10.0, will be removed in 1.11.0; use {@link
- * S3FileIO#S3FileIO(SerializableSupplier, SerializableSupplier)} with
{@link
- * S3FileIO#initialize(Map)} instead
- */
- @Deprecated
- public S3FileIO(
- SerializableSupplier<S3Client> s3,
- SerializableSupplier<S3AsyncClient> s3Async,
- S3FileIOProperties s3FileIOProperties) {
this.s3 = s3;
this.s3Async = s3Async;
- this.createStack = Thread.currentThread().getStackTrace();
- this.properties = SerializableMap.copyOf(s3FileIOProperties.properties());
Review Comment:
we want to get rid of the `S3FileIOProperties` usage in the constructors, so
we should change this to `this.properties =
SerializableMap.copyOf(Maps.newHashMap())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
