mxm commented on code in PR #14092:
URL: https://github.com/apache/iceberg/pull/14092#discussion_r2355678632
##########
core/src/main/java/org/apache/iceberg/io/WriteResult.java:
##########
@@ -134,4 +137,35 @@ public WriteResult build() {
return new WriteResult(dataFiles, deleteFiles, referencedDataFiles,
rewrittenDeleteFiles);
}
}
+
+ @Override
+ public String toString() {
+ return MoreObjects.toStringHelper(this)
+ .add("dataFiles", dataFiles)
+ .add("deleteFiles", deleteFiles)
+ .add("referencedDataFiles", referencedDataFiles)
+ .add("rewrittenDeleteFiles", rewrittenDeleteFiles)
+ .toString();
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == null || getClass() != other.getClass()) {
+ return false;
+ }
+ WriteResult that = (WriteResult) other;
+ return Objects.deepEquals(dataFiles, that.dataFiles)
+ && Objects.deepEquals(deleteFiles, that.deleteFiles)
+ && Objects.deepEquals(referencedDataFiles, that.referencedDataFiles)
+ && Objects.deepEquals(rewrittenDeleteFiles, that.rewrittenDeleteFiles);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(
+ Arrays.hashCode(dataFiles),
+ Arrays.hashCode(deleteFiles),
+ Arrays.hashCode(referencedDataFiles),
+ Arrays.hashCode(rewrittenDeleteFiles));
+ }
Review Comment:
Do we strictly need equals / hashCode for the implementation?
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -632,4 +633,72 @@ public String toString() {
.add("content_size_in_bytes", contentSizeInBytes == null ? "null" :
contentSizeInBytes)
.toString();
}
+
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ @Override
+ public boolean equals(Object other) {
+ if (other == null || getClass() != other.getClass()) {
+ return false;
+ }
+ BaseFile<?> baseFile = (BaseFile<?>) other;
+ return partitionSpecId == baseFile.partitionSpecId
+ && fileSizeInBytes == baseFile.fileSizeInBytes
+ && Objects.equals(partitionType, baseFile.partitionType)
+ && Objects.equals(fileOrdinal, baseFile.fileOrdinal)
+ && Objects.equals(manifestLocation, baseFile.manifestLocation)
+ && content == baseFile.content
+ && Objects.equals(filePath, baseFile.filePath)
+ && format == baseFile.format
+ && Objects.equals(partitionData, baseFile.partitionData)
+ && Objects.equals(recordCount, baseFile.recordCount)
+ && Objects.equals(dataSequenceNumber, baseFile.dataSequenceNumber)
+ && Objects.equals(fileSequenceNumber, baseFile.fileSequenceNumber)
+ && Objects.equals(columnSizes, baseFile.columnSizes)
+ && Objects.equals(valueCounts, baseFile.valueCounts)
+ && Objects.equals(nullValueCounts, baseFile.nullValueCounts)
+ && Objects.equals(nanValueCounts, baseFile.nanValueCounts)
+ && Objects.equals(lowerBounds, baseFile.lowerBounds)
+ && Objects.equals(upperBounds, baseFile.upperBounds)
+ && Objects.deepEquals(splitOffsets, baseFile.splitOffsets)
+ && Objects.deepEquals(equalityIds, baseFile.equalityIds)
+ && Objects.deepEquals(keyMetadata, baseFile.keyMetadata)
+ && Objects.equals(sortOrderId, baseFile.sortOrderId)
+ && Objects.equals(firstRowId, baseFile.firstRowId)
+ && Objects.equals(referencedDataFile, baseFile.referencedDataFile)
+ && Objects.equals(contentOffset, baseFile.contentOffset)
+ && Objects.equals(contentSizeInBytes, baseFile.contentSizeInBytes)
+ && Objects.equals(avroSchema, baseFile.avroSchema);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(
+ partitionType,
+ fileOrdinal,
+ manifestLocation,
+ partitionSpecId,
+ content,
+ filePath,
+ format,
+ partitionData,
+ recordCount,
+ fileSizeInBytes,
+ dataSequenceNumber,
+ fileSequenceNumber,
+ columnSizes,
+ valueCounts,
+ nullValueCounts,
+ nanValueCounts,
+ lowerBounds,
+ upperBounds,
+ Arrays.hashCode(splitOffsets),
+ Arrays.hashCode(equalityIds),
+ Arrays.hashCode(keyMetadata),
+ sortOrderId,
+ firstRowId,
+ referencedDataFile,
+ contentOffset,
+ contentSizeInBytes,
+ avroSchema);
+ }
Review Comment:
Do we absolutely need to implement equals / hascode for BaseFile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
