zeroshade commented on code in PR #558:
URL: https://github.com/apache/iceberg-go/pull/558#discussion_r2356576547
##########
catalog/rest/rest.go:
##########
@@ -750,27 +750,12 @@ func (r *Catalog) CreateTable(ctx context.Context,
identifier table.Identifier,
o(&cfg)
}
- freshSchema, err := iceberg.AssignFreshSchemaIDs(schema, nil)
- if err != nil {
- return nil, err
- }
-
- freshPartitionSpec, err :=
iceberg.AssignFreshPartitionSpecIDs(cfg.PartitionSpec, schema, freshSchema)
- if err != nil {
- return nil, err
- }
-
- freshSortOrder, err := table.AssignFreshSortOrderIDs(cfg.SortOrder,
schema, freshSchema)
- if err != nil {
- return nil, err
- }
Review Comment:
yea, the default in `CreateTableCfg` is the zero value which has `nil` for
the slice instead of an empty slice. The rest-fixture errors on the `null`.
You can fix it by adding:
```go
if cfg.SortOrder.Fields == nil {
cfg.SortOrder = table.UnsortedSortOrder
}
```
before the payload is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
