vustef commented on code in PR #1470:
URL: https://github.com/apache/iceberg-rust/pull/1470#discussion_r2357624234
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -348,19 +426,25 @@ impl TableScan {
// used to stream the results back to the caller
let (file_scan_task_tx, file_scan_task_rx) =
channel(concurrency_limit_manifest_entries);
- let (delete_file_idx, delete_file_tx) = DeleteFileIndex::new();
-
- let manifest_list = plan_context.get_manifest_list().await?;
+ // For incremental scan, disable delete file processing
Review Comment:
If we processed delete files, your PR would essentially almost be producing
a changelog, like in Spark, right? Perhaps not actionable right now, but
mentioning this as a possible extension in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
