liurenjie1024 commented on code in PR #1621:
URL: https://github.com/apache/iceberg-rust/pull/1621#discussion_r2358179446
##########
crates/sqllogictest/Cargo.toml:
##########
@@ -31,8 +31,27 @@ datafusion = { workspace = true }
datafusion-sqllogictest = { workspace = true }
enum-ordinalize = { workspace = true }
indicatif = { workspace = true }
+iceberg = { workspace = true }
+iceberg_test_utils = { path = "../test_utils", features = ["tests"] }
+iceberg-catalog-rest = { workspace = true }
+iceberg-datafusion = { workspace = true }
sqllogictest = { workspace = true }
toml = { workspace = true }
+tokio = { workspace = true }
+env_logger = "0.11.8"
+log = "0.4.25"
+itertools = "0.13.0"
+spark-connect-rs = { git = "https://github.com/apache/spark-connect-rust.git";,
rev = "061cb3ecb187b039141f20c722c7984e915f3b9d" }
+#spark-connect-rs = "0.0.2"
Review Comment:
Latest version has add requirements for protobuf. I don't quite understand
why spark-connect-rs requires cmake.
> I don't think it will block the release of iceberg rust,
The problems is that when you publish crates to crates.io, and you have a
dependency in url format, the publishing may fail. But I'm not sure if this
will affect sqllogictest, since we don't need to publish the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
