HeartLinked commented on code in PR #236: URL: https://github.com/apache/iceberg-cpp/pull/236#discussion_r2358411054
########## cmake_modules/IcebergThirdpartyToolchain.cmake: ########## @@ -430,6 +430,196 @@ function(resolve_zlib_dependency) endfunction() +# ---------------------------------------------------------------------- +# CURL (for cpr) + +function(resolve_curl_dependency) + prepare_fetchcontent() + + set(BUILD_CURL_EXE + OFF + CACHE BOOL "" FORCE) + set(BUILD_TESTING + OFF + CACHE BOOL "" FORCE) + set(CURL_ENABLE_EXPORT_TARGET + OFF + CACHE BOOL "" FORCE) + set(BUILD_SHARED_LIBS + OFF + CACHE BOOL "" FORCE) + set(CURL_STATICLIB + ON + CACHE BOOL "" FORCE) + set(HTTP_ONLY + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_LDAP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_LDAPS + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_RTSP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_FTP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_FILE + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_TELNET + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_DICT + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_TFTP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_GOPHER + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_POP3 + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_IMAP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_SMTP + ON + CACHE BOOL "" FORCE) + set(CURL_DISABLE_SMB + ON + CACHE BOOL "" FORCE) + set(CURL_CA_BUNDLE + "auto" + CACHE STRING "" FORCE) + set(USE_LIBIDN2 + OFF + CACHE BOOL "" FORCE) + + fetchcontent_declare(CURL Review Comment: This is because we don't know whether the version supplied by os fit for our cpr verison. For example, in our cpr v1.12.0, the minimum version requirement is 7.64.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
