zhangjun0x01 commented on a change in pull request #1624: URL: https://github.com/apache/iceberg/pull/1624#discussion_r508267694
########## File path: core/src/main/java/org/apache/iceberg/actions/BaseAction.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.List; +import org.apache.iceberg.MetadataTableType; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.TableOperations; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +abstract class BaseAction<R> implements Action<R> { + + protected abstract Table table(); + + protected String metadataTableName(MetadataTableType type) { + return metadataTableName(table().name(), type); + } + + protected String metadataTableName(String tableName, MetadataTableType type) { + if (tableName.contains("/")) { + return tableName + "#" + type; + } else if (tableName.startsWith("hadoop.")) { + // for HadoopCatalog tables, use the table location to load the metadata table + // because IcebergCatalog uses HiveCatalog when the table is identified by name + return table().location() + "#" + type; + } else if (tableName.startsWith("hive.")) { + // HiveCatalog prepend a logical name which we need to drop for Spark 2.4 + return tableName.replaceFirst("hive\\.", "") + "." + type; Review comment: Flink is not used for the time being. I think this method is used for metadata, so I also extracted it. Currently we have not done RewriteManifestsAction and ExpireSnapshotsAction for flink. I think if we do it in the future, it should be useful ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
