slfan1989 commented on code in PR #13913:
URL: https://github.com/apache/iceberg/pull/13913#discussion_r2364993020
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -80,6 +82,22 @@ public Integer asInt(ProcedureParameter param, Integer
defaultValue) {
return args.isNullAt(ordinal) ? defaultValue : (Integer)
args.getInt(ordinal);
}
+ public long asTimestampLong(ProcedureParameter param) {
+ Long value = asTimestampLong(param, null);
+ Preconditions.checkArgument(value != null, "Parameter '%s' is not set",
param.name());
+ return value;
+ }
+
+ public Long asTimestampLong(ProcedureParameter param, Long defaultValue) {
Review Comment:
Thank you for reviewing the code. I will make the adjustments based on your
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
