aheev commented on PR #14142: URL: https://github.com/apache/iceberg/pull/14142#issuecomment-3316128335
@c-thiel I have a couple of queries regarding the implementation - I took inspiration from [Namespace](https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/catalog/Namespace.java#L28) class for implementing `CatalogObject`. So, should we support EMPTY_CATALOG_OBJECT too, just like EMPTY_NAMESPACE? - Should we add validation checks like `null`, `empty` checks for required fields in [operations](https://github.com/apache/iceberg/blob/b3aa3a5d78f53653b92a6cb8c7323c78c37e31fc/core/src/main/java/org/apache/iceberg/rest/operations/CreateTableOperation.java), request and response object classes? - I am assuming in [QueryEventsRequest](https://github.com/apache/iceberg/pull/12584/files#diff-02549ca620d020dc9ead80088cc14e311e12a69651fa8d394cd41a4308debb2eR3535), we would only be supporting standard operation types and 'custom'. We would not support filtering on custom operation types like 'x-\<some-op\>' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
