vinjai commented on code in PR #2485: URL: https://github.com/apache/iceberg-python/pull/2485#discussion_r2366823096
########## tests/integration/test_add_files.py: ########## Review Comment: It should be same as the test for appending to non-existing branch: https://github.com/apache/iceberg-python/blob/caf02ee6bd268b9b3257706a531d280b9ad15a91/tests/integration/test_writes/test_writes.py#L2096 If seen from the POV of a snapshot, the flow for add_files and append operation is same as only a new snapshot with new files is being appended. Since, we are not adding any different code, it just introduces another test which goes through the same flow thus increasing test time. My suggestion would be to not bloat the test time with similar tests Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
