pvary commented on code in PR #14148:
URL: https://github.com/apache/iceberg/pull/14148#discussion_r2366958788
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -223,6 +232,30 @@ public static void assertRowData(
}
}
+ private static @Nullable Object getExpectedValue(
+ Map<Integer, Object> idToConstant,
+ int pos,
+ Types.NestedField expectedField,
+ Record expected) {
+ Object expectedValue;
+ int id = expectedField.fieldId();
+ if (id == MetadataColumns.ROW_ID.fieldId()) {
+ expectedValue = expected.getField(expectedField.name());
+ if (expectedValue == null && idToConstant != null) {
+ expectedValue = (Long) idToConstant.get(id) + pos;
+ }
+
+ } else if (id == MetadataColumns.LAST_UPDATED_SEQUENCE_NUMBER.fieldId()) {
+ expectedValue = expected.getField(expectedField.name());
+ if (expectedValue == null && idToConstant != null) {
+ expectedValue = idToConstant.get(id);
+ }
+ } else {
+ expectedValue = expected.getField(expectedField.name());
+ }
Review Comment:
But we need one here 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
