nastra commented on code in PR #13933: URL: https://github.com/apache/iceberg/pull/13933#discussion_r2368818370
########## api/src/main/java/org/apache/iceberg/stats/StatsUtil.java: ########## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.stats; + +import static org.apache.iceberg.types.Types.NestedField.optional; + +import java.util.Comparator; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; +import org.apache.iceberg.Schema; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.TypeUtil; +import org.apache.iceberg.types.Types; + +public class StatsUtil { + static final int COLUMN_SIZE_OFFSET = 0; + static final int VALUE_COUNT_OFFSET = 1; + static final int NULL_VALUE_COUNT_OFFSET = 2; + static final int NAN_VALUE_COUNT_OFFSET = 3; + static final int LOWER_BOUND_OFFSET = 4; + static final int UPPER_BOUND_OFFSET = 5; + static final int NUM_STATS_PER_COLUMN = 200; + static final int RESERVED_FIELD_IDS = 200; + static final int DATA_SPACE_FIELD_ID_START = 10_000; + static final int METADATA_SPACE_FIELD_ID_START = 2_147_000_000; + static final int RESERVED_FIELD_IDS_START = Integer.MAX_VALUE - RESERVED_FIELD_IDS; + // support stats for only up to this amount of data field IDs + static final int MAX_DATA_FIELD_ID = 1_000_000; + + private StatsUtil() {} + + public static int statsFieldIdForField(int fieldId) { + return fieldId >= RESERVED_FIELD_IDS_START + ? statsFieldIdForReservedField(fieldId) + : statsFieldIdForDataField(fieldId); + } + + private static int statsFieldIdForDataField(int fieldId) { + long statsFieldId = DATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) fieldId; + if (fieldId > MAX_DATA_FIELD_ID || statsFieldId < 0) { + return -1; + } + + return (int) statsFieldId; + } + + private static int statsFieldIdForReservedField(int fieldId) { + int offset = RESERVED_FIELD_IDS - (Integer.MAX_VALUE - fieldId); + + long statsFieldId = METADATA_SPACE_FIELD_ID_START + NUM_STATS_PER_COLUMN * (long) offset; + if (statsFieldId < 0 || statsFieldId > RESERVED_FIELD_IDS_START) { + // ID overflows + return -1; + } + + return (int) statsFieldId; + } + + public static int fieldIdForStatsField(int statsFieldId) { + if (statsFieldId < 0 || statsFieldId % NUM_STATS_PER_COLUMN != 0) { + return -1; Review Comment: also instead of checking < 0 it's actually better to check < 10_000 because stats field IDs will always be >= 10_000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
