rdblue commented on a change in pull request #1638: URL: https://github.com/apache/iceberg/pull/1638#discussion_r509739816
########## File path: parquet/src/test/java/org/apache/iceberg/parquet/TestCDHParquetStatistics.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.parquet; + +import org.apache.parquet.column.statistics.Statistics; +import org.junit.Assert; +import org.junit.Test; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +/** + * Tests for Parquet 1.5.0-Stats which cannot be evaluated like later versions of Parquet stats. They are intercepted + * by the hasNonNullButNoMinMax function which always returns ROWS_MAY_MATCH + */ +public class TestCDHParquetStatistics { + + @Test + public void testCDHParquetStatistcs() { + Statistics cdhBinaryColumnStats = mock(Statistics.class); + when(cdhBinaryColumnStats.getMaxBytes()).thenReturn(null); + when(cdhBinaryColumnStats.getMinBytes()).thenReturn(null); + when(cdhBinaryColumnStats.getNumNulls()).thenReturn(0L); + Assert.assertTrue(ParquetMetricsRowGroupFilter.hasNonNullButNoMinMax(cdhBinaryColumnStats, 50L)); Review comment: Should we also test -1 for num nulls? I know we don't expect it, but the behavior should still be correct, I think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
