Fokko commented on PR #14163: URL: https://github.com/apache/iceberg/pull/14163#issuecomment-3322848281
@kevinjqliu It was late yesterday, but I wanted to get something out. It looks like the last snipper you shared shows the right approach rather than relaxing constraints: https://github.com/apache/iceberg/blob/16fa673782233eb2b692d463deb8be3e52c5f378/core/src/main/java/org/apache/iceberg/MergeAppend.java#L57-L59 Instead, we set it to -1, and the SnapshotManager will take care of setting the SnapshotID. @amogh-jahagirdar Thanks for the review, I've added some tests 👍 @nastra Do you have time to check out the JUnit conventions? I'm not doing Java often enough :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
