stubz151 commented on code in PR #13997:
URL: https://github.com/apache/iceberg/pull/13997#discussion_r2372814744


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1340,6 +1340,7 @@ public <D> CloseableIterable<D> build() {
           optionsBuilder.withDecryption(fileDecryptionProperties);
         }
 
+        optionsBuilder.withUseHadoopVectoredIo(true);

Review Comment:
   For part 1 about the effort to reduce the dependencies on Hadoop I don't 
think that was ever completed I do see a TODO comment about wanting to do it. I 
am probably making the effort more complicated as I am adding 2 new imports 
from Hadoop but I don't think that is a big risk.
   
   
   for 2) withUseHadoopVectoredIo is used in the file reader in conjunction 
with  readVectoredAvailable() so moving to always using readVector doesn't 
change anything unless the stream also supports readVectored.
   
https://github.com/apache/parquet-java/blob/f50dd6cb4b526cf4b585993c1b69a838cd8151f3/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L1303



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to