nastra commented on code in PR #14065:
URL: https://github.com/apache/iceberg/pull/14065#discussion_r2374904311


##########
docs/docs/configuration.md:
##########
@@ -143,6 +143,43 @@ The properties can be manually constructed or passed in 
from a compute engine li
 Spark uses its session properties as catalog properties, see more details in 
the [Spark configuration](spark-configuration.md#catalog-configuration) section.
 Flink passes in catalog properties through `CREATE CATALOG` statement, see 
more details in the [Flink](flink.md#adding-catalogs) section.
 
+### Catalog REST auth properties
+
+The following catalog properties configure authentication for the REST catalog.
+They support Basic, OAuth2, SigV4, and Google authentication.
+
+### REST auth properties
+
+| Property                             | Default          | Description        
                                                                                
               |
+|--------------------------------------|------------------|-------------------------------------------------------------------------------------------------------------------|
+| `rest.auth.type`                     | `none`             | Authentication 
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`, 
`sigv4`, `google`. |

Review Comment:
   ```suggestion
   | `rest.auth.type`                     | `none`            | Authentication 
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`, 
`sigv4`, `google`. |
   ```



##########
docs/docs/configuration.md:
##########
@@ -143,6 +143,43 @@ The properties can be manually constructed or passed in 
from a compute engine li
 Spark uses its session properties as catalog properties, see more details in 
the [Spark configuration](spark-configuration.md#catalog-configuration) section.
 Flink passes in catalog properties through `CREATE CATALOG` statement, see 
more details in the [Flink](flink.md#adding-catalogs) section.
 
+### Catalog REST auth properties
+
+The following catalog properties configure authentication for the REST catalog.
+They support Basic, OAuth2, SigV4, and Google authentication.
+
+### REST auth properties
+
+| Property                             | Default          | Description        
                                                                                
               |
+|--------------------------------------|------------------|-------------------------------------------------------------------------------------------------------------------|
+| `rest.auth.type`                     | `none`             | Authentication 
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`, 
`sigv4`, `google`. |

Review Comment:
   ```suggestion
   | `rest.auth.type`                     | `none`           | Authentication 
mechanism for REST catalog access. Supported values: `none`, `basic`, `oauth2`, 
`sigv4`, `google`. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to