HeartLinked commented on code in PR #242: URL: https://github.com/apache/iceberg-cpp/pull/242#discussion_r2378041123
########## src/iceberg/util/uuid.cc: ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/util/uuid.h" + +#include <chrono> +#include <cstdint> +#include <cstring> +#include <random> +#include <string> + +#include "iceberg/exception.h" +#include "iceberg/result.h" +#include "iceberg/util/int128.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +Uuid::Uuid(std::array<uint8_t, kUuidSize> data) : data_(std::move(data)) {} + +Uuid Uuid::GenerateV4() { + static std::random_device rd; + static std::mt19937 gen(rd()); + static std::uniform_int_distribution<uint64_t> distrib( + std::numeric_limits<uint64_t>::min(), std::numeric_limits<uint64_t>::max()); + std::array<uint8_t, 16> uuid; + + // Generate two random 64-bit integers + uint64_t high_bits = distrib(gen); + uint64_t low_bits = distrib(gen); + + // Combine them into a uint128_t + uint128_t random_128_bit_number = (static_cast<uint128_t>(high_bits) << 64) | low_bits; + + // Copy the bytes into the uuid array + std::memcpy(uuid.data(), &random_128_bit_number, 16); + + // Set magic numbers for a "version 4" (pseudorandom) UUID and variant, + // see https://datatracker.ietf.org/doc/html/rfc9562#name-uuid-version-4 + uuid[6] = (uuid[6] & 0x0F) | 0x40; + // Set variant field, top two bits are 1, 0 + uuid[8] = (uuid[8] & 0x3F) | 0x80; + + return Uuid(std::move(uuid)); +} + +Uuid Uuid::GenerateV7() { + // Get the current time in milliseconds since the Unix epoch + auto now = std::chrono::system_clock::now(); + auto duration_since_epoch = now.time_since_epoch(); + auto unix_ts_ms = + std::chrono::duration_cast<std::chrono::milliseconds>(duration_since_epoch).count(); + + return GenerateV7(static_cast<uint64_t>(unix_ts_ms)); +} + +Uuid Uuid::GenerateV7(uint64_t unix_ts_ms) { + std::array<uint8_t, 16> uuid = {}; + + // Set the timestamp (in milliseconds since Unix epoch) + uuid[0] = (unix_ts_ms >> 40) & 0xFF; + uuid[1] = (unix_ts_ms >> 32) & 0xFF; + uuid[2] = (unix_ts_ms >> 24) & 0xFF; + uuid[3] = (unix_ts_ms >> 16) & 0xFF; + uuid[4] = (unix_ts_ms >> 8) & 0xFF; + uuid[5] = unix_ts_ms & 0xFF; + + // Generate random bytes for the remaining fields + static std::random_device rd; + static std::mt19937 gen(rd()); + static std::uniform_int_distribution<uint16_t> distrib( + std::numeric_limits<uint16_t>::min(), std::numeric_limits<uint16_t>::max()); + + // Note: uint8_t is invalid for uniform_int_distribution on Windows + for (size_t i = 6; i < 16; i += 2) { + auto rand = static_cast<uint16_t>(distrib(gen)); + uuid[i] = (rand >> 8) & 0xFF; + uuid[i + 1] = rand & 0xFF; + } + + // Set magic numbers for a "version 7" (pseudorandom) UUID and variant, + // see https://www.rfc-editor.org/rfc/rfc9562#name-version-field + uuid[6] = (uuid[6] & 0x0F) | 0x70; + // set variant field, top two bits are 1, 0 + uuid[8] = (uuid[8] & 0x3F) | 0x80; + + return Uuid(std::move(uuid)); +} + +namespace { Review Comment: Only a small suggestion: to improve readability, I suggest moving the anonymous namespace to the top or end of the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
