szehon-ho commented on code in PR #13837: URL: https://github.com/apache/iceberg/pull/13837#discussion_r2378096699
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java: ########## @@ -91,12 +91,14 @@ public class RewriteTablePathSparkAction extends BaseSparkAction<RewriteTablePat private static final Logger LOG = LoggerFactory.getLogger(RewriteTablePathSparkAction.class); private static final String RESULT_LOCATION = "file-list"; + static final String NOT_APPLICABLE = "N/A"; Review Comment: sorry just noticed one thing, this seems a bit awkward. Was there some discussion on just having an empty string, or does the result object not allow it? In any case, I feel it can be private here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
