shangxinli commented on code in PR #14153:
URL: https://github.com/apache/iceberg/pull/14153#discussion_r2379032543
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -827,6 +827,11 @@ public DataWriteBuilder createWriterFunc(
return this;
}
+ public DataWriteBuilder variantShreddingFunc(VariantShreddingFunction
func) {
+ appenderBuilder.variantShreddingFunc(func);
Review Comment:
Should we add null check? something like
Preconditions.checkArgument(func != null, "Variant shredding function cannot
be null");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
