Fokko opened a new issue, #2520:
URL: https://github.com/apache/iceberg-python/issues/2520

   ### Feature Request / Improvement
   
   Make sure that the `not` expression can be serialized to JSON:
   
   
https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/expressions/__init__.py#L332
   
   This should follow:
   
   ```json
   {
       "type": "not",
       "child": BooleanExpression
   }
   ```
   
   Where BooleanExpression refers to the class:
   
   
https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/expressions/__init__.py#L250
   
   We use Pydantic for JSON serialization, which can be enabled by deriving 
from the `IcebergBaseModel`:
   
   
https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/partitioning.py#L124
   
   Example tests can be found here:
   
   
https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/tests/table/test_partitioning.py#L116-L132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to