yuboxx opened a new pull request, #14186: URL: https://github.com/apache/iceberg/pull/14186
**Summary** - The logic in [BaseReplacePartitions.apply()](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java#L114) doesn't run unpartitioned table check correctly. It simply counts for the fields in the partition spec without checking if they have void transform applied. This leads to the wrong behavior when `insert overwrite` runs on a table with partition columns removed, where it's supposed to replace the entire partitions instead of overwriting the partitions affected. The expected behavior is described in the public [doc](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java#L114). **Change** - Modified the check to use the method in `PartitionSpec`, which includes the void transform check. **Test Plan** - Tested locally using Iceberg 1.4 and Spark 3.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
