pvary commented on code in PR #14191:
URL: https://github.com/apache/iceberg/pull/14191#discussion_r2385215493
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java:
##########
@@ -39,6 +39,18 @@ public class DynamicRecord {
private boolean upsertMode;
@Nullable private Set<String> equalityFields;
+ /**
+ * Constructs a new DynamicRecord.
+ *
+ * @param tableIdentifier The target table identifier.
+ * @param branch The target table branch.
+ * @param schema The target table schema.
+ * @param rowData The data matching the provided schema.
+ * @param partitionSpec The target table {@link PartitionSpec}.
+ * @param distributionMode The {@link DistributionMode}.
+ * @param writeParallelism The number of parallel writers. If set to
{@literal <= 0}, will
Review Comment:
What if we set it to `MAX_INT`. It is easier to calculate with `min` later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
