liurenjie1024 commented on PR #1666: URL: https://github.com/apache/iceberg-rust/pull/1666#issuecomment-3346089905
Hi, @335g I'm not convinced that we should remove `Default` for `CatalogBuilder`, as the default method provides a default constructor for it. >SqlCatalog requires iceberg::FileIO, but implementing Default to allow users to select the storage location proves challenging. It's `CatalogBuilder` that requires implementing `Default`, not `SqlCatalog`. I took a look at the code and I think storing `FileIO` in `SqlCatalogConfig` is incorrect, `FileIO` should be inferred from warehouse location. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
