adutra commented on code in PR #14178: URL: https://github.com/apache/iceberg/pull/14178#discussion_r2398682597
########## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java: ########## Review Comment: Another issue here is that I think we need to synchronize on the instantiation of this cache. Looking at `S3V4RestSignerClient` I think this method could be called by more than one thread in parallel. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
