Fokko commented on code in PR #2557:
URL: https://github.com/apache/iceberg-python/pull/2557#discussion_r2399917750
##########
pyiceberg/expressions/__init__.py:
##########
@@ -559,8 +561,10 @@ def as_bound(self) -> Type[BoundNotNaN[L]]:
return BoundNotNaN[L]
-class SetPredicate(UnboundPredicate[L], ABC):
- literals: Set[Literal[L]]
+class SetPredicate(UnboundPredicate[L], IcebergBaseModel, ABC):
+ type: str = Field(default="in", alias="type")
+ term: str
Review Comment:
This one is actually defined in the parent class:
https://github.com/apache/iceberg-python/blob/6913b11ae1abbe0cfb05bfb0232fe66f6de437be/pyiceberg/expressions/__init__.py#L417
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
