ebyhr commented on code in PR #14212:
URL: https://github.com/apache/iceberg/pull/14212#discussion_r2400210802
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -2114,6 +2114,22 @@ public void createViewWithCustomMetadataLocation() {
""));
}
+ @TestTemplate
Review Comment:
Is the reason for not backporting to v3.4 that's deprecated #14099?
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -2113,6 +2113,22 @@ public void createViewWithCustomMetadataLocation() {
""));
}
+ @TestTemplate
+ public void createViewWithCustomMetadataLocationWithLocation() {
+ String viewName = viewName("v");
+ String customMetadataLocation =
+ Paths.get(temp.toUri().toString(),
"custom-metadata-location").toString();
+ sql(
+ "CREATE VIEW %s TBLPROPERTIES ('location'='%s') AS SELECT * FROM %s",
+ viewName, customMetadataLocation, tableName);
+
+ assertThat(sql("SHOW TBLPROPERTIES %s", viewName))
+ .contains(row("location", customMetadataLocation));
+
+ String location = viewCatalog().loadView(TableIdentifier.of(NAMESPACE,
viewName)).location();
+ assertThat(location).isEqualTo(customMetadataLocation);
+ }
+
Review Comment:
I think there is a minor difference between `write.metadata.path` and
`location` in UNSET/SET TBLPROPERTIES statement.
`write.metadata.path` isn't a reserved property, so it can be modified or
unset. In contrast, `location` is a reserved property, so it can no longer be
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
