wgtmac commented on code in PR #230:
URL: https://github.com/apache/iceberg-cpp/pull/230#discussion_r2387239094
##########
src/iceberg/catalog/CMakeLists.txt:
##########
@@ -16,6 +16,7 @@
# under the License.
iceberg_install_all_headers(iceberg/catalog)
+add_subdirectory(memory)
Review Comment:
```suggestion
add_subdirectory(memory)
```
##########
src/iceberg/catalog/rest/CMakeLists.txt:
##########
@@ -34,7 +34,6 @@ list(APPEND
ICEBERG_REST_SHARED_INSTALL_INTERFACE_LIBS
"$<IF:$<TARGET_EXISTS:Iceberg::iceberg_shared>,Iceberg::iceberg_shared,Iceberg::iceberg_static>"
"$<IF:$<BOOL:${CPR_VENDORED}>,Iceberg::cpr,cpr::cpr>")
-
Review Comment:
Please revert this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
