pvary commented on code in PR #14245:
URL: https://github.com/apache/iceberg/pull/14245#discussion_r2414580112
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestRowDataWrapper.java:
##########
@@ -59,6 +63,57 @@ public void testTime() {
});
}
+ /** Test that nanosecond precision timestamps are preserved correctly. */
+ @Test
+ public void testNanosecondTimestampPrecision() {
+ // Create a specific timestamp with nanosecond precision
+ LocalDateTime testTime = LocalDateTime.of(2025, 10, 2, 10, 15, 30,
123456789);
+ long expectedMicros = DateTimeUtil.microsFromTimestamp(testTime);
+ long expectedNanos = DateTimeUtil.nanosFromTimestamp(testTime);
Review Comment:
Are these used?
##########
gradle.properties:
##########
@@ -32,4 +32,4 @@ org.gradle.parallel=true
org.gradle.configureondemand=true
# explicitly disable the configuration cache
org.gradle.configuration-cache=false
-org.gradle.jvmargs=-Xmx1536m
+org.gradle.jvmargs=-Xmx1536m
Review Comment:
nit: revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
