rambleraptor commented on code in PR #2429:
URL: https://github.com/apache/iceberg-python/pull/2429#discussion_r2427524189
##########
tests/table/test_upsert.py:
##########
@@ -440,6 +441,75 @@ def test_create_match_filter_single_condition() -> None:
)
[email protected](
+ "data, expected",
+ [
+ pytest.param(
+ [{"x": 1.0}, {"x": 2.0}, {"x": 3.0}],
+ In(Reference(name="x"), {DoubleLiteral(1.0), DoubleLiteral(2.0),
DoubleLiteral(3.0)}),
+ id="single-column-without-null",
+ ),
+ pytest.param(
+ [{"x": 1.0}, {"x": 2.0}, {"x": None}, {"x": 4.0}, {"x":
float("nan")}],
+ Or(
+ left=IsNull(term=Reference(name="x")),
+ right=Or(
+ left=IsNaN(term=Reference(name="x")),
+ right=In(Reference(name="x"), {DoubleLiteral(1.0),
DoubleLiteral(2.0), DoubleLiteral(4.0)}),
+ ),
+ ),
+ id="single-column-with-null",
+ ),
+ pytest.param(
+ [
+ {"x": 1.0, "y": 9.0},
+ {"x": 2.0, "y": None},
+ {"x": None, "y": 7.0},
+ {"x": 4.0, "y": float("nan")},
+ {"x": float("nan"), "y": 0.0},
+ ],
+ Or(
+ left=Or(
+ left=And(
+ left=EqualTo(term=Reference(name="x"),
literal=DoubleLiteral(1.0)),
+ right=EqualTo(term=Reference(name="y"),
literal=DoubleLiteral(9.0)),
+ ),
+ right=And(
+ left=EqualTo(term=Reference(name="x"),
literal=DoubleLiteral(2.0)),
+ right=IsNull(term=Reference(name="y")),
+ ),
+ ),
+ right=Or(
+ left=And(
+ left=IsNull(term=Reference(name="x")),
+ right=EqualTo(term=Reference(name="y"),
literal=DoubleLiteral(7.0)),
+ ),
+ right=Or(
+ left=And(
+ left=EqualTo(term=Reference(name="x"),
literal=DoubleLiteral(4.0)),
+ right=IsNaN(term=Reference(name="y")),
+ ),
+ right=And(
+ left=IsNaN(term=Reference(name="x")),
+ right=EqualTo(term=Reference(name="y"),
literal=DoubleLiteral(0.0)),
+ ),
+ ),
+ ),
+ ),
+ id="multi-column-with-null",
+ ),
+ ],
+)
+def test_create_match_filter(data: list[dict[str, Any]], expected:
BooleanExpression) -> None:
Review Comment:
style nit: This is a rare case where I think the parameterization makes the
code harder to read. I think it's worth having the code duplication and just
creating two different tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
