liurenjie1024 commented on code in PR #1735:
URL: https://github.com/apache/iceberg-rust/pull/1735#discussion_r2439096953
##########
crates/iceberg/src/writer/mod.rs:
##########
@@ -260,8 +270,8 @@ pub trait IcebergWriterBuilder<I = DefaultInput, O =
DefaultOutput>:
{
/// The associated writer type.
type R: IcebergWriter<I, O>;
- /// Build the iceberg writer.
- async fn build(self) -> Result<Self::R>;
+ /// Build the iceberg writer for an optional partition key.
+ async fn build_with_partition(self, partition_key: Option<PartitionKey>)
-> Result<Self::R>;
Review Comment:
Thanks for explaination, that makes sense to me. It would be better to
create an issue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
