rdblue commented on pull request #1640: URL: https://github.com/apache/iceberg/pull/1640#issuecomment-715546468
My main concern with this is how configuration is currently passed using Hadoop `Configuration`. We want to avoid using `Configuration` and only pass it where it is needed for our use of Hadoop APIs, like `FileSystem`. Passing `Configuration` as the last argument is fine because many catalogs will currently need it to use `HadoopFileIO`, but we'll need an alternative as well. I think we also want to pass options from the catalog config in Flink and Spark, where users can pass properties like `uri` and `warehouse`. Could you add a `Map` to this to pass the catalog config options? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
