HuaHuaY commented on code in PR #255:
URL: https://github.com/apache/iceberg-cpp/pull/255#discussion_r2426308011
##########
src/iceberg/type.h:
##########
@@ -83,28 +83,27 @@ class ICEBERG_EXPORT NestedType : public Type {
bool is_nested() const override { return true; }
/// \brief Get a view of the child fields.
- [[nodiscard]] virtual std::span<const SchemaField> fields() const = 0;
+ virtual std::span<const SchemaField> fields() const = 0;
using SchemaFieldConstRef = std::reference_wrapper<const SchemaField>;
/// \brief Get a field by field ID.
///
/// \note This is O(1) complexity.
- [[nodiscard]] virtual Result<std::optional<SchemaFieldConstRef>>
GetFieldById(
+ virtual Result<std::optional<SchemaFieldConstRef>> GetFieldById(
Review Comment:
It may be better to reserve `[[nodiscard]]` before `Result<>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
