danielcweeks commented on code in PR #14264: URL: https://github.com/apache/iceberg/pull/14264#discussion_r2440548486
########## core/src/main/java/org/apache/iceberg/DeleteManifestCache.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import com.github.benmanes.caffeine.cache.Cache; +import com.github.benmanes.caffeine.cache.Caffeine; +import java.util.List; +import java.util.Objects; +import java.util.concurrent.TimeUnit; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; + +/** + * Cache for parsed delete file entries from manifests to avoid redundant manifest parsing across + * changelog scans. + * + * <p>This cache is thread-safe and uses LRU eviction with size and time-based expiration. + */ +class DeleteManifestCache { Review Comment: I'm somewhat sceptical of using a cache here. 1k entries is really only good for smaller cases and once you've exhausted that, the value of the cache degrates rapidly. I'm a little concerned that at larger scales the cache will be completely ineffective as entries would just cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
