singhpk234 commented on code in PR #14360:
URL: https://github.com/apache/iceberg/pull/14360#discussion_r2440640343
##########
build.gradle:
##########
@@ -363,6 +361,7 @@ project(':iceberg-core') {
implementation libs.jackson.core
implementation libs.jackson.databind
implementation libs.caffeine
+ implementation libs.opentelemetry.httpclient
Review Comment:
do we need to update and LICENCE ?
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
Review Comment:
how does the E2E flows works does the Trino works, does it creates its own
HTTPClient and in the builder sets its won OpenTelemetry client ?
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -529,6 +533,11 @@ public Builder withAuthSession(AuthSession session) {
return this;
}
+ public Builder withOpenTelemetry(OpenTelemetry openTelemetry) {
+ this.telemetry = openTelemetry;
+ return this;
+ }
Review Comment:
how is the openTelemetry configuration provided, via ENV ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
