HuaHuaY commented on code in PR #257:
URL: https://github.com/apache/iceberg-cpp/pull/257#discussion_r2430994549
##########
src/iceberg/util/string_util.h:
##########
@@ -44,6 +44,12 @@ class ICEBERG_EXPORT StringUtils {
[](char c) { return std::toupper(c); }); // NOLINT
return input;
}
+
+ static bool EqualsIgnoreCase(const std::string& a, const std::string& b) {
+ return a.size() == b.size() && std::ranges::equal(a, b, [](char ca, char
cb) {
Review Comment:
`std::ranges::equal` will compare length so we don't need to write `a.size()
== b.size()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
