rdblue edited a comment on pull request #1559: URL: https://github.com/apache/iceberg/pull/1559#issuecomment-715594455
Good to understand the points about rename with overwrite flag. Since there isn't an overwrite flag in the API we use, let's go with delete and rename for this. The current approach looks good to me. I think the only thing that needs to be updated is that the boolean args need to be documented. I agree with the choice to fail the create if the unique file already exists, but the comment should be there so it can be understood easily. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
