slfan1989 commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2428337376
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestZkLockFactory.java:
##########
@@ -29,7 +29,15 @@ public class TestZkLockFactory extends TestLockFactoryBase {
@Override
TriggerLockFactory lockFactory(String tableName) {
- return new ZkLockFactory(zkTestServer.getConnectString(), tableName, 5000,
3000, 1000, 3);
+ return new ZkLockFactory(
+ zkTestServer.getConnectString(),
+ tableName,
+ 5000,
+ 3000,
+ 1000,
+ 3,
+ 2000,
+ ZKRetryPolicies.EXPONENTIAL_BACKOFF.name());
Review Comment:
Thank you for the suggestion! I’ve added some unit tests. Since these retry
strategies are implemented and maintained by Apache Curator, I think it should
be sufficient to verify that the configuration parameters can be correctly
parsed and mapped. Does that sound reasonable to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
