HuaHuaY commented on code in PR #181: URL: https://github.com/apache/iceberg-cpp/pull/181#discussion_r2386859034
########## src/iceberg/row/struct_like.h: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +/// \file iceberg/row/struct_like.h +/// Structures for viewing data in a row-based format. This header contains the +/// definition of StructLike, ArrayLike, and MapLike which provide an unified +/// interface for viewing data from ArrowArray or structs like ManifestFile and +/// ManifestEntry. Note that they do not carry type information and should be +/// used in conjunction with the schema to get the type information. + +#include <memory> +#include <string_view> +#include <variant> +#include <vector> + +#include "iceberg/result.h" +#include "iceberg/type_fwd.h" +#include "iceberg/util/decimal.h" + +namespace iceberg { + +/// \brief A scalar value depending on its data type. +/// +/// Note that all string and binary values are stored as non-owned string_view +/// and their lifetime is managed by the wrapped object. +using Scalar = std::variant<std::monostate, // for null + bool, // for boolean + int32_t, // for int, date + int64_t, // for long, timestamp, timestamp_tz, and time + float, // for float + double, // for double + std::string_view, // for non-owned string, binary and fixed + Decimal, // for decimal + std::shared_ptr<StructLike>, // for struct Review Comment: In which case will a class except `ArrowArrayStructLike ` inherit `StructLike`? ########## src/iceberg/row/struct_like.h: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +/// \file iceberg/row/struct_like.h +/// Structures for viewing data in a row-based format. This header contains the +/// definition of StructLike, ArrayLike, and MapLike which provide an unified +/// interface for viewing data from ArrowArray or structs like ManifestFile and +/// ManifestEntry. Note that they do not carry type information and should be +/// used in conjunction with the schema to get the type information. + +#include <memory> +#include <string_view> +#include <variant> +#include <vector> + +#include "iceberg/result.h" +#include "iceberg/type_fwd.h" +#include "iceberg/util/decimal.h" + +namespace iceberg { + +/// \brief A scalar value depending on its data type. +/// +/// Note that all string and binary values are stored as non-owned string_view +/// and their lifetime is managed by the wrapped object. +using Scalar = std::variant<std::monostate, // for null + bool, // for boolean + int32_t, // for int, date + int64_t, // for long, timestamp, timestamp_tz, and time + float, // for float + double, // for double + std::string_view, // for non-owned string, binary and fixed + Decimal, // for decimal + std::shared_ptr<StructLike>, // for struct Review Comment: In which case will a class except `ArrowArrayStructLike` inherit `StructLike`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
