twuebi commented on code in PR #585:
URL: https://github.com/apache/iceberg-go/pull/585#discussion_r2413748460
##########
table/metadata.go:
##########
@@ -743,6 +753,11 @@ func (b *MetadataBuilder) SetLastUpdatedMS()
*MetadataBuilder {
return b
}
+func (b *MetadataBuilder) SetNextRowID(nextRowID int64) *MetadataBuilder {
+ b.nextRowID = &nextRowID
+ return b
+}
Review Comment:
do we need a setter here? On what occasion would we want to set this from
the outside?
It probably makes sense to not expose this to library users. My current
understanding is that we only need to increment this in AddSnapshot based on
the number of added rows in the snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
