nastra commented on code in PR #14351:
URL: https://github.com/apache/iceberg/pull/14351#discussion_r2438431198
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -423,8 +442,10 @@ public void testPositionDeletes() throws Exception {
.hasSize(1);
}
- @Test
- public void testPositionDeleteWithRow() throws Exception {
+ @TestTemplate
+ public void testV2PositionDeleteFilesWithRow() throws Exception {
+ assumeThat(formatVersion).isEqualTo(2);
Review Comment:
same as above, you need to pass the `formatVersion` to
FileHelpers.writeDeleteFile(..) and let the test run with all format versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
