nandorKollar commented on code in PR #14266:
URL: https://github.com/apache/iceberg/pull/14266#discussion_r2424627936
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetConversions.java:
##########
@@ -83,6 +83,9 @@ static Function<Object, Object> converterFromParquet(
} else if (icebergType.typeId() == Type.TypeID.DOUBLE
&& parquetType.getPrimitiveTypeName() ==
PrimitiveType.PrimitiveTypeName.FLOAT) {
return value -> ((Float) fromParquet.apply(value)).doubleValue();
+ } else if (icebergType.typeId() == Type.TypeID.TIMESTAMP
+ && parquetType.getOriginalType() ==
org.apache.parquet.schema.OriginalType.DATE) {
+ return value -> (long) ((Integer) fromParquet.apply(value)) *
86400_000_000L;
Review Comment:
Furthermore, shouldn't we also fail, when the Iceberg type is UTC adjusted
(`timestamptz` or `timestamptz_ns`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
