rdblue commented on pull request #1573: URL: https://github.com/apache/iceberg/pull/1573#issuecomment-715627628
@danielcweeks, I did a fairly thorough review and found some problems in the read path (not updating positions, seek falling back to new connection). Those also expose some test gaps. Otherwise, there are two things I'd fix: * It would be really nice to depend on only one version of the AWS SDK. If the URI class is only used to parse path and bucket, can we replace it with something? @jackye1995, any ideas? * Implement `create`. We can do this in a follow-up, but it seems like it will bite us if we don't and forget ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
