laserninja commented on code in PR #14354: URL: https://github.com/apache/iceberg/pull/14354#discussion_r2441580868
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java: ########## @@ -67,6 +67,9 @@ public class ExpireSnapshotsSparkAction extends BaseSparkAction<ExpireSnapshotsS public static final String STREAM_RESULTS = "stream-results"; public static final boolean STREAM_RESULTS_DEFAULT = false; + public static final String LOG_EXPIRE_FILES = "log-expire-files"; + public static final boolean LOG_EXPIRE_FILES_DEFAULT = false; Review Comment: Nit: Should this be an enum `LOG_EXPIRE_FILES_DEFAULT`? Where can we have different levels of log details? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
