dongxiao1198 commented on code in PR #261:
URL: https://github.com/apache/iceberg-cpp/pull/261#discussion_r2438524873
##########
src/iceberg/v1_metadata.cc:
##########
@@ -47,15 +50,14 @@ Status ManifestEntryAdapterV1::Init() {
DataFile::kSplitOffsets.field_id(),
DataFile::kSortOrderId.field_id(),
};
- // TODO(xiao.dong) schema to json
- metadata_["schema"] = "{}";
- // TODO(xiao.dong) partition spec to json
- metadata_["partition-spec"] = "{}";
+ ICEBERG_RETURN_UNEXPECTED(InitSchema(kManifestEntryFieldIds));
+ metadata_["schema"] = ToJson(*manifest_schema_).dump();
Review Comment:
I really think we should make toJson like this. This way we can ignore the
nlohmann:: outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
