wgtmac commented on code in PR #177: URL: https://github.com/apache/iceberg-cpp/pull/177#discussion_r2376143553
########## src/iceberg/expression/term.cc: ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "iceberg/expression/term.h" + +#include <format> + +#include "iceberg/exception.h" +#include "iceberg/result.h" +#include "iceberg/schema.h" +#include "iceberg/transform.h" +#include "iceberg/util/checked_cast.h" +#include "iceberg/util/macros.h" + +namespace iceberg { + +Bound::~Bound() = default; + +BoundTerm::~BoundTerm() = default; + +Reference::~Reference() = default; + +template <typename B> +Result<std::shared_ptr<B>> Unbound<B>::Bind(const Schema& schema) const { + return Bind(schema, /*case_sensitive=*/true); Review Comment: It is already supported by the interface: ``` class ICEBERG_EXPORT Unbound { public: /// \brief Bind this expression to a concrete schema. /// /// \param schema The schema to bind against /// \param case_sensitive Whether field name matching should be case sensitive /// \return A bound expression or an error if binding fails virtual Result<std::shared_ptr<B>> Bind(const Schema& schema, bool case_sensitive) const = 0; /// \brief Overloaded Bind method that uses case-sensitive matching by default. Result<std::shared_ptr<B>> Bind(const Schema& schema) const; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
