pvary commented on PR #14092: URL: https://github.com/apache/iceberg/pull/14092#issuecomment-3346726545
@aiborodin: We are trying to do too many things parallel in this PR and it makes it hard to review. Here are the separate features I see here: 1. Fixing the correctness issue 2. Adding convenience equals and hashcode implementations for BaseFile and WriteResult 3. Moving the aggregation of the commits from the committer to the Aggregator 4. Changing the state serialization mode for the Committable Here is how I see the changes 1-by-1: 1. Fixing is a must 2. I'm afraid that the community will push back on this. You can separate out this to another PR, and see what other people think about it. I still feel that this could be a behavioral change in the core part of Iceberg, which we should not do, but I can be convinced otherwise 3. This is a very good idea, and I fully support this 4. I think the current one is not ideal, and I'm happy to talk about it, but I suggest that we do it in a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
