pvary commented on PR #14245: URL: https://github.com/apache/iceberg/pull/14245#issuecomment-3370476121
@talatuyarer: Could we please limit the changes to Flink 2.1, so it is easier to review, and easier to update based on the review comments? Also, could you please review the generated tests, and make sure that the relevant tests are there and we don't have tests which are redundant? One mora suggestion: DataGenerators is used in tests to automatically add tests for the types. Please add timestamp nano to them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
