Fokko commented on code in PR #233:
URL: https://github.com/apache/iceberg-cpp/pull/233#discussion_r2428784170
##########
.github/workflows/test.yml:
##########
@@ -99,3 +99,36 @@ jobs:
run: |
call "C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
bash -c "ci/scripts/build_example.sh $(pwd)/example"
+ meson:
+ name: Meson - ${{ matrix.title }}
+ runs-on: ${{ matrix.runs-on }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - title: AMD64 Ubuntu 24.04
+ runs-on: ubuntu-24.04
+ - title: AMD64 Windows 2025
+ runs-on: windows-2025
+ meson-setup-args: --vsenv
+ - title: AArch64 macOS 15
+ runs-on: macos-15
+ steps:
+ - uses: actions/setup-python@v5
+ with:
+ python-version: '3.x'
+ - name: Checkout iceberg-cpp
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Install build dependencies
+ run: |
+ python3 -m pip install --upgrade pip
+ python3 -m pip install meson ninja
Review Comment:
Should we pin these on a specific version? Otherwise, the version might be
bumped without anyone knowing, and which could break the build.
##########
.github/workflows/test.yml:
##########
@@ -99,3 +99,36 @@ jobs:
run: |
call "C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
bash -c "ci/scripts/build_example.sh $(pwd)/example"
+ meson:
+ name: Meson - ${{ matrix.title }}
+ runs-on: ${{ matrix.runs-on }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - title: AMD64 Ubuntu 24.04
+ runs-on: ubuntu-24.04
+ - title: AMD64 Windows 2025
+ runs-on: windows-2025
+ meson-setup-args: --vsenv
+ - title: AArch64 macOS 15
+ runs-on: macos-15
+ steps:
+ - uses: actions/setup-python@v5
+ with:
+ python-version: '3.x'
+ - name: Checkout iceberg-cpp
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Install build dependencies
+ run: |
+ python3 -m pip install --upgrade pip
+ python3 -m pip install meson ninja
Review Comment:
We could move it to a `requirements.txt` and let dependabot maintain the
versions.
```suggestion
python3 -m pip install -r requirements.txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
