fbocse edited a comment on issue #1496: URL: https://github.com/apache/iceberg/issues/1496#issuecomment-716417087
@pvary ah yes, you are right, there's no dead-lock on account of out-of-order writes from committer to metadata version files (snapshots) or version-hint text file based on that code snippet. Regardless of the version hint the code will try to detect the most recent snapshot by incrementally traversing snapshot files, right? So worst case is what? Version hint is a bit behind from recent snapshot (cause there's no compare-and-swap (CAS) operation when we update the version hint)? Readers still get to the most recent snapshot though based on the snippet you've shared, just have to pay the cost to traverse the snapshots list (this can be reduced by a subsequent writer to align version hint with most recent version). Lgtm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
